-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] fieldservice_activity #1183
[17.0][MIG] fieldservice_activity #1183
Conversation
[IMP] Typo [IMP] Form/Template Change [IMP] Show/Hide Buttons [IMP] PyLint [IMP] Remove Commented Code [IMP] Lint
Currently translated at 96.3% (26 of 27 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_activity Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_activity/es_CL/
Currently translated at 100.0% (27 of 27 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_activity Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_activity/es_CL/
Currently translated at 100.0% (27 of 27 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_activity Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_activity/pt_BR/
Currently translated at 100.0% (27 of 27 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_activity Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_activity/es_AR/
Currently translated at 100.0% (27 of 27 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_activity Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_activity/pt_PT/
Currently translated at 100.0% (27 of 27 strings) Translation: field-service-13.0/field-service-13.0-fieldservice_activity Translate-URL: https://translation.odoo-community.org/projects/field-service-13-0/field-service-13-0-fieldservice_activity/es_AR/
Currently translated at 100.0% (28 of 28 strings) Translation: field-service-14.0/field-service-14.0-fieldservice_activity Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice_activity/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: field-service-15.0/field-service-15.0-fieldservice_activity Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_activity/
Currently translated at 100.0% (27 of 27 strings) Translation: field-service-15.0/field-service-15.0-fieldservice_activity Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_activity/it/
Currently translated at 100.0% (27 of 27 strings) Translation: field-service-16.0/field-service-16.0-fieldservice_activity Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_activity/es/
Currently translated at 100.0% (27 of 27 strings) Translation: field-service-16.0/field-service-16.0-fieldservice_activity Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_activity/pt_BR/
Currently translated at 100.0% (27 of 27 strings) Translation: field-service-16.0/field-service-16.0-fieldservice_activity Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_activity/pt_BR/
/ocabot migration fieldservice_activity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi
Code review, it looks good.
Thx for the work
@Deriman-Alonso or @max3903 |
da0afde
to
ce5345b
Compare
@DorianMAG Pre-commit changed some stuff in intex.html, hopefully runboat will run now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi
LGTM
thx
This PR has the |
Thx, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional testing failed.
Unable to edit read-only fields conditioned by expression. Syntax changed in v17.
The XML syntax is as follows:
https://www.odoo.com/documentation/17.0/developer/reference/user_interface/view_architectures/field_attribute_readonly.html
but I have not found the syntax for declaring fields in Python.
I will look into it, Ty for review. |
string="Complete" | ||
type="object" | ||
class="oe_highlight" | ||
invisible="('state', 'not in', ['todo'])" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, the syntax change for:
invisible="state not in ['todo']"
Superseded by #1211 |
Standart migration.