Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] fieldservice_activity #1183

Closed

Conversation

Deriman-Alonso
Copy link
Member

Standart migration.

osi-scampbell and others added 30 commits April 23, 2024 14:10
[IMP] Typo

[IMP] Form/Template Change

[IMP] Show/Hide Buttons

[IMP] PyLint

[IMP] Remove Commented Code

[IMP] Lint
Currently translated at 96.3% (26 of 27 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_activity/es_CL/
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_activity/es_CL/
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_activity/pt_BR/
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_activity/es_AR/
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_activity/pt_PT/
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-13.0/field-service-13.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-13-0/field-service-13-0-fieldservice_activity/es_AR/
Currently translated at 100.0% (28 of 28 strings)

Translation: field-service-14.0/field-service-14.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice_activity/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-15.0/field-service-15.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_activity/
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_activity/it/
Ivorra78 and others added 6 commits April 23, 2024 14:10
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-16.0/field-service-16.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_activity/es/
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-16.0/field-service-16.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_activity/pt_BR/
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-16.0/field-service-16.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_activity/pt_BR/
@max3903 max3903 modified the milestone: 17.0 Jun 17, 2024
@max3903
Copy link
Member

max3903 commented Jun 17, 2024

/ocabot migration fieldservice_activity

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jun 17, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 17, 2024
46 tasks
Copy link

@DorianMAG DorianMAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
Code review, it looks good.
Thx for the work

@DorianMAG
Copy link

@Deriman-Alonso or @max3903
Possible to rebase plz.
Runboat doesn't work

@Deriman-Alonso
Copy link
Member Author

@DorianMAG Pre-commit changed some stuff in intex.html, hopefully runboat will run now.

Copy link

@JulienMartinez JulienMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
LGTM
thx

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@DorianMAG
Copy link

@DorianMAG Pre-commit changed some stuff in intex.html, hopefully runboat will run now.

Thx,
perfect was work :)

Copy link

@DorianMAG DorianMAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional testing failed.
Unable to edit read-only fields conditioned by expression. Syntax changed in v17.

https://github.com/OCA/field-service/pull/1183/files#diff-e7e26d6a3ed185daa05317dcf7ed3457ff1831d1fb55c788d669372c2d38fd4dR12

The XML syntax is as follows:
https://www.odoo.com/documentation/17.0/developer/reference/user_interface/view_architectures/field_attribute_readonly.html

but I have not found the syntax for declaring fields in Python.

@Deriman-Alonso
Copy link
Member Author

I will look into it, Ty for review.

string="Complete"
type="object"
class="oe_highlight"
invisible="('state', 'not in', ['todo'])"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, the syntax change for:

invisible="state not in ['todo']"

@dreispt
Copy link
Member

dreispt commented Sep 14, 2024

Superseded by #1211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.